[PATCH] D152401: CGExprCXX: emit family and allockind attributes
James Y Knight via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 13 13:17:10 PDT 2023
jyknight added a comment.
> As a result, clang/llvm should correctly
> optimize custom allocators like this without needing specialized
> knowledge going forward.
Not exactly: we still need knowledge of this in //clang// (`isReplaceableGlobalAllocationFunction` was taught that the variant with a `__hot_cold_t` parameter //is// a replaceable global allocation function, without which knowledge this optimization cannot apply). However we do get rid of that from //llvm//, which is a nice cleanup!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152401/new/
https://reviews.llvm.org/D152401
More information about the cfe-commits
mailing list