[PATCH] D148700: [clang] Add support for “regular” keyword attributes

[Richard Sandiford via Phabricator via cfe-commits]

rsandifo-arm added a comment.

Hi @jyknight , @rsmith

Do you have any more thoughts on the above?  Quick version is:

1. Is it OK to have `[[…]]` attributes in the `arm` namespace that affect semantics?
2. Is it OK to raise an error for unrecognised attributes in the `arm` namespace (for a measure of future-proofing)?

Given the differing views, I'm unsure whether to revert the series and do (1) (and possibly (2)), or whether to leave things as they are.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148700/new/

https://reviews.llvm.org/D148700