[PATCH] D152391: [Clang] Allow bitcode linking when the input is LLVM-IR

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 marked an inline comment as not done.
jhuber6 added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:2052-2106
+void clang::CodeGen::mergeDefaultFunctionDefinitionAttributes(
+    llvm::Function &F, const CodeGenOptions CodeGenOpts,
+    const LangOptions &LangOpts, const TargetOptions &TargetOpts,
+    bool WillInternalize) {
+
+  llvm::AttrBuilder FuncAttrs(F.getContext());
+  if (!TargetOpts.CPU.empty())
----------------
yaxunl wrote:
> can we reorder these functions to minimize the diffs? Also some comments about the difference among these functions may help.
I added some comments. These can't be reordered because they're new functions, I simply added a layer of indirection to go through a common helper so we can call the main bulk of the code without needing the full `CGM`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152391/new/

https://reviews.llvm.org/D152391