[PATCH] D150358: [clang][Interp] Remove args from called functions in more cases

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 07:36:30 PDT 2023


aaron.ballman added inline comments.


================
Comment at: clang/test/AST/Interp/functions.cpp:262
+namespace CallWithArgs {
+  /// This used to call problems during checkPotentialConstantExpression() runs.
+  constexpr void g(int a) {}
----------------
tbaeder wrote:
> aaron.ballman wrote:
> > 
> Question regarding this: IIRC it was @MaskRay who once told me to use `///` comments for everything that's not a `RUN` or `expected` line. If you look further up, I think I stuck to that (mostly). Should I continue doing that or not?
Oh yeah, you did mostly stick to that; then ignore my suggestion. However, we have no policy regarding `//` vs `///` vs `/**/`, so it's pretty much a case-by-case basis, but in general we use `//` for all comments unless there's a specific reason not to.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150358/new/

https://reviews.llvm.org/D150358



More information about the cfe-commits mailing list