[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 07:34:54 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

In D152525#4408902 <https://reviews.llvm.org/D152525#4408902>, @tbaeder wrote:

> As far as the fixit goes, I guess the previous version was better, since it didn't leave an empty line behind?

Yes, but that's a formatting-related concern with the output, and we traditionally leave that to another tool like clang-format to address.

LGTM, but add a release note since there technically is a change in behavior with the fix-it?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152525/new/

https://reviews.llvm.org/D152525



More information about the cfe-commits mailing list