[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

I think precommit CI may have found a relevant failure:

  ******************** TEST 'Clang :: Index/IBOutletCollection.m' FAILED ********************
  Script:
  --
  : 'RUN: at line 8';   c:\ws\w5\llvm-project\premerge-checks\build\bin\c-index-test.exe -cursor-at=C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m:4:24 C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m | c:\ws\w5\llvm-project\premerge-checks\build\bin\filecheck.exe -check-prefix=CHECK-CURSOR C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m
  : 'RUN: at line 11';   c:\ws\w5\llvm-project\premerge-checks\build\bin\c-index-test.exe -test-annotate-tokens=C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m:4:1:5:1 C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m | c:\ws\w5\llvm-project\premerge-checks\build\bin\filecheck.exe -check-prefix=CHECK-TOK C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m
  --
  Exit Code: 1
   
  Command Output (stdout):
  --
  $ ":" "RUN: at line 8"
  $ "c:\ws\w5\llvm-project\premerge-checks\build\bin\c-index-test.exe" "-cursor-at=C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m:4:24" "C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m"
  $ "c:\ws\w5\llvm-project\premerge-checks\build\bin\filecheck.exe" "-check-prefix=CHECK-CURSOR" "C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m"
  # command stderr:
  C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m:9:18: error: CHECK-CURSOR: expected string not found in input
  // CHECK-CURSOR: ObjCClassRef=Test:3:12
                   ^
  <stdin>:1:1: note: scanning from here
  4:3 attribute(iboutletcollection)= [IBOutletCollection=ObjCInterface] Extent=[4:3 - 4:27]
  ^
  <stdin>:1:54: note: possible intended match here
  4:3 attribute(iboutletcollection)= [IBOutletCollection=ObjCInterface] Extent=[4:3 - 4:27]
                                                       ^
   
  Input file: <stdin>
  Check file: C:\ws\w5\llvm-project\premerge-checks\clang\test\Index\IBOutletCollection.m
   
  -dump-input=help explains the following input dump.
   
  Input was:
  <<<<<<
             1: 4:3 attribute(iboutletcollection)= [IBOutletCollection=ObjCInterface] Extent=[4:3 - 4:27]
  check:9'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
  check:9'1                                                          ?                                     possible intended match
  >>>>>>
   
  error: command failed with exit status: 1
   
  --
   
  ********************



================
Comment at: clang/unittests/libclang/LibclangTest.cpp:1176
+TEST_F(LibclangParseTest, ExposedAnnotateArgs) {
+  // TODO
+  const char testSource[] = R"cpp(
----------------
Spurious comment?


================
Comment at: clang/unittests/libclang/LibclangTest.cpp:1178
+  const char testSource[] = R"cpp(
+int [[clang::annotate_type("category_type", 42)]] f;
+
----------------
We don't seem to be testing this?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151373/new/

https://reviews.llvm.org/D151373