[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

Tue Jun 13 00:58:15 PDT 2023

owenpan added a comment.

In D151761#4410998 <https://reviews.llvm.org/D151761#4410998>, @HazardyKnusperkeks wrote:

> In D151761#4410158 <https://reviews.llvm.org/D151761#4410158>, @galenelias wrote:
>
>> Yah, I think leaving it open would be my preference at this point.  Not sure how to properly document that though?  Just be explicit in the tests?  Mention it in `alignConsecutiveShortCaseStatements`?  Should it be documented in the generated documentation (that feels a bit heavy)?
>
> It will be a known issue, and thus it should be documented explicitly in my opinion. Otherwise there will be bug reports. So I would do:
>
> - Mention it in the options documentation.
> - Add a FIXME comment where the fix most likely would be applied.
> - Comment on test cases that they have to be changed once this is fixed - or add tests which are within an `#if 0`, don't know what @MyDeveloperDay or @owenpan like better.

I prefer the latter, and IIRC @MyDeveloperDay doesn't use the former.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151761/new/

https://reviews.llvm.org/D151761