[PATCH] D152696: Prevent deadlocks in death tests.
Martin Böhme via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 13 00:06:16 PDT 2023
mboehme updated this revision to Diff 530789.
mboehme added a comment.
Set the `death_test_style` flag globally in TestMain.cpp instead of each
individual test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152696/new/
https://reviews.llvm.org/D152696
Files:
third-party/unittest/UnitTestMain/TestMain.cpp
Index: third-party/unittest/UnitTestMain/TestMain.cpp
===================================================================
--- third-party/unittest/UnitTestMain/TestMain.cpp
+++ third-party/unittest/UnitTestMain/TestMain.cpp
@@ -29,6 +29,10 @@
true /* Disable crash reporting */);
}
+ // Use the "threadsafe" test style for death tests -- the "fast" test style
+ // can cause deadlocks.
+ testing::GTEST_FLAG(death_test_style) = "threadsafe";
+
// Initialize both gmock and gtest.
testing::InitGoogleMock(&argc, argv);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152696.530789.patch
Type: text/x-patch
Size: 579 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230613/631ef4a7/attachment.bin>
More information about the cfe-commits
mailing list