[PATCH] D151785: [clangd] Desugar template parameter aliases in type hints

Nathan Ridge via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 13 00:05:12 PDT 2023


nridge accepted this revision.
nridge added a comment.
This revision is now accepted and ready to land.

Thanks, LGTM!



================
Comment at: clang-tools-extra/clangd/InlayHints.cpp:196
+// Determines if any intermediate type in desugaring QualType QT is of
+// substituted template parameter. Ignore pointer or reference wrappers.
+bool isSugaredTemplateParameter(QualType QT) {
----------------
nit: "of substituted template parameter" --> "a substituted template parmeter" 

(or "of substituted template parameter type")


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151785/new/

https://reviews.llvm.org/D151785



More information about the cfe-commits mailing list