[PATCH] D152762: [clang][docs] Update SanitizerSpecialCaseList docs

[Fangrui Song via Phabricator via cfe-commits]

MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.

> "The meaning of * in regular expression for entity names is different - it is treated as in shell wildcarding."

Right. See `SpecialCaseList.cpp`

> I've removed fun:MyFooBar since it made it seem like we could match demangled names.

Yes, this is a limitation that we cannot match just C files (`src:*.c` matches `.cc` and `.cpp` files as well)...



================
Comment at: clang/test/CodeGen/profile-filter-new.c:1
-// RUN: %clang_cc1 -fprofile-instrument=llvm -emit-llvm %s -o - | FileCheck %s --implicit-check-not="; {{.* (noprofile|skipprofile)}}"
+// RUN: split-file %s %t
 
----------------
is more robust since if `%t` previously exists as a file (stale file after testing), the new test will fail...

`rm -rf %t` is also clear that all files in the old directory are removed, so more difficult to reference dangling files after updating tests...

`// RUN: rm -rf %t && split-file %s %t && cd %t` is common as well to avoid `%t/` occurrences...


================
Comment at: clang/test/CodeGen/profile-filter-new.c:11
 
+//--- Inputs/src/code.c
 // SKIP-FOO: skipprofile
----------------
Consider dropping `Inputs/` for all files. It's unneeded and misleading (not in the source directory).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152762/new/

https://reviews.llvm.org/D152762