[PATCH] D150602: [clang-tidy] Move formatDereference to FixitHintUtils

[Mike Crowe via Phabricator via cfe-commits]

mikecrowe updated this revision to Diff 530662.
mikecrowe added a comment.

Add clangTooling to LINK_LIBS for tooling::fixit::getText for clangTidyUtils to fix failure to build with BUILD_SHARED_LIBS=ON:

  ld.lld: error: undefined symbol: clang::tooling::fixit::internal::getText(clang::CharSourceRange, clang::ASTContext const&)
  >>> referenced by FixItHintUtils.cpp
  >>>               tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/obj.clangTidyUtils.dir/FixItHintUtils.cpp.o:(clang::tidy::utils::fixit::formatDereference[abi:cxx11](clang::Expr const&, clang::ASTContext const&))
  >>> referenced by FixItHintUtils.cpp
  >>>               tools/clang/tools/extra/clang-tidy/utils/CMakeFiles/obj.clangTidyUtils.dir/FixItHintUtils.cpp.o:(clang::tidy::utils::fixit::formatDereference[abi:cxx11](clang::Expr const&, clang::ASTContext const&))

I've no idea whether this is a sensible solution, but it does seem to work in my testing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150602/new/

https://reviews.llvm.org/D150602

Files:
  clang-tools-extra/clang-tidy/readability/RedundantStringCStrCheck.cpp
  clang-tools-extra/clang-tidy/utils/CMakeLists.txt
  clang-tools-extra/clang-tidy/utils/FixItHintUtils.cpp
  clang-tools-extra/clang-tidy/utils/FixItHintUtils.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D150602.530662.patch
Type: text/x-patch
Size: 5787 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230612/b28d27cd/attachment.bin>