[PATCH] D152734: [HIP] Fix HIP path detection

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 12 10:51:55 PDT 2023


yaxunl created this revision.
yaxunl added a reviewer: tra.
Herald added subscribers: kerbowa, jvesely.
Herald added a project: All.
yaxunl requested review of this revision.
Herald added a subscriber: MaskRay.

Fix two issues:

1. `--hip-path` should not do rigorous checking, i.e. if .hipVersion exists it will use it, otherwise it will not error out but assumes the default HIP version. This is to be consistent with --rocm-path behavior.

2. when HIP_PATH is empty, it should be ignored. This is to be consistent with ROCM_PATH behavior.


https://reviews.llvm.org/D152734

Files:
  clang/lib/Driver/ToolChains/AMDGPU.cpp
  clang/test/Driver/hip-version.hip
  clang/test/Driver/rocm-detect.hip

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152734.530589.patch
Type: text/x-patch
Size: 4480 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230612/0f3dec3d/attachment.bin>


More information about the cfe-commits mailing list