[PATCH] D152689: [NFC] Remove dead conditionals

Mon Jun 12 05:03:24 PDT 2023

aaron.ballman added a subscriber: rjmccall.
aaron.ballman added a comment.

The other two changes LGTM, but the objc changes bring up a question about what the correct fix is.

================
Comment at: clang/lib/CodeGen/CGObjCMac.cpp:3812
   llvm::GlobalVariable *GV;
-  if (ForClass)
-    GV =
----------------
I agree this is dead code (see line 3777-3778 above), but @rjmccall is it a bug that we bail out with a null value (e.g, is the correct fix to remove the above lines)?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152689/new/

https://reviews.llvm.org/D152689