[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

Mon Jun 12 04:50:52 PDT 2023

skatrak added a comment.

Thank you for the feedback. I expect I will be able to refactor the `analyzeOpenMPDeclarative()` function to OpenMP.cpp as suggested, but I'll bring that together with other changes to make it integrate cleanly with the latest changes to D149337 <https://reviews.llvm.org/D149337>. Since that patch now moves a big part of the gathering of 'requires' clauses to the prior semantics step, this patch can be simplified to rely on that.

================
Comment at: flang/lib/Lower/Bridge.cpp:271
+        bridge{bridge}, foldingContext{bridge.createFoldingContext()},
+        ompRequiresFlags{mlir::omp::ClauseRequires::none} {}
   virtual ~FirConverter() = default;
----------------
kiranchandramohan wrote:
> Is this set anywhere? If not is it required? Can this be made available through the bridge?
The `ompRequiresFlags` field is set by the `analyzeOpenMPDeclarative` method, called for each 'omp requires' directive in the PFT.

I'm not sure if I understand what you mean by making this available through the bridge. Do you suggest creating a public method to access these flags?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D147218/new/

https://reviews.llvm.org/D147218