[PATCH] D152685: [clangd] Decouple IncludeCleaner implementation from Config

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 12 02:34:54 PDT 2023


hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.

Thanks, this looks good!



================
Comment at: clang-tools-extra/clangd/IncludeCleaner.h:60
+issueIncludeCleanerDiagnostics(ParsedAST &AST, llvm::StringRef Code,
+                               IncludeCleanerFindings Findings,
+                               HeaderFilter IgnoreHeader = {});
----------------
nit: `const IncludeCleanerFindings&`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152685/new/

https://reviews.llvm.org/D152685



More information about the cfe-commits mailing list