[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines= as a driver option

Mon Jun 12 01:00:33 PDT 2023

tbaeder marked an inline comment as done.
tbaeder added inline comments.

================
Comment at: clang/include/clang/Driver/Options.td:2303
+  Group<f_Group>, Flags<[NoXarchOption, CC1Option, CoreOption]>,
+  HelpText<"Set the maximum number of source lines to show in a caret diagnostic">,
+  MarshallingInfoInt<DiagnosticOpts<"SnippetLineLimit">, "DiagnosticOptions::DefaultSnippetLineLimit">;
----------------
MaskRay wrote:
> MaskRay wrote:
> > Add ` (0 = no limit)` if useful
> `NoXarchOption` emits an error if an option is used after `-Xarch_*`. The feature only applies to a small set of options (e.g. `-o`) and is not very useful for most options, but `NoXarchOption` was improperly named `DriverOption` and lured some contributors to add `NoXarchOption` to options that should not have the flag.
> 
> For `fcaret-diagnostics-max-lines=`, we should remove `NoXarchOption`.
Removed it, thanks for the explanation. I guess this should be removed from `-fmacro-backtrace-limit` as well?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152090/new/

https://reviews.llvm.org/D152090