[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jun 12 00:51:42 PDT 2023


kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks a lot for bearing with me, LGTM!

let me know if i should land this for you.



================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:165
   bool CollectInactiveRegions;
+  const ClangdServer::Options &Opts;
 };
----------------
nit: no need to store a reference to whole Options struct, you can have single boolean.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148088/new/

https://reviews.llvm.org/D148088



More information about the cfe-commits mailing list