[PATCH] D145849: [Driver][xray] Allow XRay on Apple Silicon

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

This is a kinda odd case. Normally we should enable the option in the driver when the feature actually works.
However, `Triple.isMacOSX()` is allowed before the feature actually works and `compiler-rt/test/xray/lit.cfg.py` tests it.

`clang/test/Driver/XRay/` is broken and does not follow the practice testing driver changes.
`clang/test/Driver` should not test code generation but `XRay/` tests do.

The targets aren't really enabled since `REQUIRES: aarch64 || x86_64 || x86_64h` lines specified lit features aren't available.



================
Comment at: clang/lib/Driver/XRayArgs.cpp:66
+    default:
+      D.Diag(diag::err_drv_clang_unsupported)
+          << (std::string(XRayInstrumentOption) + " on " + Triple.str());
----------------
The file was written in a non-conventional way. I just cleaned up the file a bit.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D145849/new/

https://reviews.llvm.org/D145849