[PATCH] D152473: [clang-format] Add test case for issue 63170

Fri Jun 9 16:49:34 PDT 2023

paulkirth marked an inline comment as done.
paulkirth added a comment.

In D152473#4410331 <https://reviews.llvm.org/D152473#4410331>, @MyDeveloperDay wrote:

> My additional concern is, is the original patch is the root cause of the regression?, so I’m struggling to understand why this in particular is being reverted or are we just going backwards through all commits?

I'm not sure I follow, can you elaborate on what you mean here?  Reverting only 4b9764959dc4b8783e18747c1742ab164e4bc4ee <https://reviews.llvm.org/rG4b9764959dc4b8783e18747c1742ab164e4bc4ee> will allow the new test added here to pass, but tests added in d2627cf88d2553a4c2e850430bdb908a4b7d2e52 <https://reviews.llvm.org/rGd2627cf88d2553a4c2e850430bdb908a4b7d2e52> will fail, since they require the behavior added in 4b9764959dc4b8783e18747c1742ab164e4bc4ee <https://reviews.llvm.org/rG4b9764959dc4b8783e18747c1742ab164e4bc4ee>.  Reverting them both is required to keep tests passing.

================
Comment at: clang/test/Format/overlapping-lines.cpp:1
+// RUN: grep -Ev "// *[A-Z-]+:" %s | clang-format --style=Google 2>&1 | FileCheck %s 
+// CHECK-NOT: The new replacement overlaps with an existing replacement.
----------------
MyDeveloperDay wrote:
> please remove this.
removed in https://reviews.llvm.org/rGa28a46665529992cefb78049da79f2125f6b6c2d

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152473/new/

https://reviews.llvm.org/D152473