[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

Min-Yih Hsu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 9 14:53:59 PDT 2023


myhsu marked 3 inline comments as done.
myhsu added inline comments.


================
Comment at: clang/test/CodeGen/mrtd.c:4
 
-// CHECK: mrtd.c:10:3: warning: function with no prototype cannot use the stdcall calling convention
+// CHECK: mrtd.c:13:3: warning: function with no prototype cannot use the stdcall calling convention
 
----------------
jrtc27 wrote:
> Ew... this should be using -verify and `// expected-warning {{...}}`, then the line number is relative to the comment's location. Or, really, it should be in the Sema test...
> 
> Plus is it correct to call this stdcall on m68k? The GCC manpage only mentions it in the x86 option description, not the m68k one.
Now this check is moved to `test/Sema/m68k-mrtd.c`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D149867/new/

https://reviews.llvm.org/D149867



More information about the cfe-commits mailing list