[PATCH] D152473: [clang-format] Add test case for issue 63170

Fri Jun 9 14:14:04 PDT 2023

paulkirth added a comment.

In D152473#4409975 <https://reviews.llvm.org/D152473#4409975>, @MyDeveloperDay wrote:

> In D152473#4409146 <https://reviews.llvm.org/D152473#4409146>, @paulkirth wrote:
>
>> The point of this patch was to show a regression. I'm not trying to fix anything per se. I'd like https://reviews.llvm.org/D151954  and anything that depends on it reverted, since it breaks `clang-format`.
>
> I think its respectful to wait a little for the code owners to give you a LG unless the patch is breaking the unit tests.

So first, no one here is trying to be disrespectful, we're all here to make the compiler and surrounding tools better for everyone. That said, it's also normally respectful to revert changes when others report that your patch has a serious regression.  https://llvm.org/docs/DeveloperPolicy.html#patch-reversion-policy

I'm not sure how common this is, but in this case we found a test case that was missing from the unit tests, otherwise the patches that were reverted would never have landed. So, while I understand your point, reverting here is in line w/ the communities policies. If there is a different interpretation I should have on the policy, I'm happy to hear it, but as I read it, our response here is in line w/ our typical developer expectations. My apologies if any of this comes off as rude (being nuanced in text is hard) but I'm trying to be very clear about my interpretation and rationale.

As a last point we've had our CI broken by this since the initial patch landed, and it's been several days since we first reported the issue. We're certainly not trying to be discourteous w/ our actions, but it I also don't think it's reasonable to expect that when community members report a serious regression, file an issue, and provide a reproducer that they be expected to wait days for a revert or forward fix.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152473/new/

https://reviews.llvm.org/D152473