[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

Yuanfang Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 9 12:50:17 PDT 2023


ychen marked an inline comment as done.
ychen added inline comments.


================
Comment at: clang/test/SemaTemplate/aggregate-deduction-candidate.cpp:101
+
+  template <typename T> struct E {
+    T t;
----------------
shafik wrote:
> I would also like to see this test:
> 
> ```
> template <typename T>
> struct I {
>   using type = T;
> };
> 
> template <typename T>
> struct E {
>   typename I<T>::type i;
>   T t;
> };
> 
> E e1 = {1, 2}; // OK, E<int> deduced
> ```
> 
> Since it is in the paper, this should cover it but it can't hurt.
Yep, just added this test.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D139837/new/

https://reviews.llvm.org/D139837



More information about the cfe-commits mailing list