[PATCH] D152570: [clang] Fix file mapping template arguments

[Shafik Yaghmour via Phabricator via cfe-commits]

shafik added inline comments.


================
Comment at: clang/lib/AST/Expr.cpp:789
 
+    class PrettyCallbacks final : public PrintingCallbacks {
+    public:
----------------
This looks consistent with how other places that set `CallBacks` but I am not familiar with this area. 


================
Comment at: clang/lib/AST/Expr.cpp:791
+    public:
+      PrettyCallbacks(const LangOptions &L) : LO(L) {}
+      std::string remapPath(StringRef Path) const override {
----------------
This may not be a well known idiom but is widely used within llvm.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152570/new/

https://reviews.llvm.org/D152570