[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

Fri Jun 9 09:48:35 PDT 2023

oontvoo added a comment.

In D144999#4409149 <https://reviews.llvm.org/D144999#4409149>, @Michael137 wrote:

> In D144999#4408248 <https://reviews.llvm.org/D144999#4408248>, @Michael137 wrote:
>
>> Looks like the latest reland of this patch (`e60b30d5e3878e7d91f8872ec4c4dca00d4a2dfc`) broke some debug-info `cross-project-tests` on the Arm64 macOS buildbots: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-as/263/execution/node/54/log/
>>
>>   Failed Tests (2):
>>     cross-project-tests :: debuginfo-tests/dexter-tests/optnone-fastmath.cpp
>>     cross-project-tests :: debuginfo-tests/dexter-tests/optnone-struct-and-methods.cpp
>>
>> You can run those tests by adding `cross-project-tests` to `LLVM_ENABLE_PROJECTS` and running `ninja check-debuginfo`.
>>
>> AFAICT, it also broke following LLDB test (https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake-as/263/execution/node/65/log/):
>>
>>   Failed Tests (1):
>>     lldb-api :: functionalities/step-avoids-no-debug/TestStepNoDebug.py
>>
>> Let me know if you need help reproducing this
>
> Mind taking a look or reverting the patch until the tests pass?

Yes - having a look now - wasn't able to repro the test failure before because the build broke at HEAD:

  /mnt/ssd/repo/llvm-project/llvm/include/llvm/CodeGen/RDFRegisters.h: In member function ‘constexpr size_t llvm::rdf::RegisterRef::hash() const’:
  /mnt/ssd/repo/llvm-project/llvm/include/llvm/CodeGen/RDFRegisters.h:92:35: error: call to non-‘constexpr’ function ‘std::size_t std::hash<unsigned int>::operator()(unsigned int) const’
     92 |     return std::hash<RegisterId>{}(Reg) ^
        |            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D144999/new/

https://reviews.llvm.org/D144999