[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

[Matt Arsenault via Phabricator via cfe-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

lgtm with nit



================
Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:280
+    } else {
+      auto AllocSize = M->getDataLayout().getTypeAllocSize(Args[i]->getType());
+      if (AllocSize <= 8)
----------------
BufSize += std::max(getTypeAllocSize(), 8)


================
Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:369
+    if (DL.getTypeAllocSize(Ty) < 8) {
+      return Builder.CreateFPExt(Arg, Builder.getDoubleTy());
+    }
----------------
maybe add a constrained fp run line to a test


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150427/new/

https://reviews.llvm.org/D150427