[PATCH] D150358: [clang][Interp] Remove args from called functions in more cases

Timm Bäder via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jun 9 08:17:44 PDT 2023


tbaeder added a subscriber: MaskRay.
tbaeder added inline comments.


================
Comment at: clang/test/AST/Interp/functions.cpp:262
+namespace CallWithArgs {
+  /// This used to call problems during checkPotentialConstantExpression() runs.
+  constexpr void g(int a) {}
----------------
aaron.ballman wrote:
> 
Question regarding this: IIRC it was @MaskRay who once told me to use `///` comments for everything that's not a `RUN` or `expected` line. If you look further up, I think I stuck to that (mostly). Should I continue doing that or not?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150358/new/

https://reviews.llvm.org/D150358



More information about the cfe-commits mailing list