[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)
Youngsuk Kim via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jun 8 09:58:47 PDT 2023
JOE1994 added inline comments.
================
Comment at: clang/lib/CodeGen/CGBuilder.h:172
+ auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace());
return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty,
Addr.getAlignment(), Addr.isKnownNonNull());
----------------
nikic wrote:
> Can remove this bit cast.
Wouldn't removing the bitcast cause behavior change for uses of `CreateElementBitCast` that supply a `Name` that is not `""`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152321/new/
https://reviews.llvm.org/D152321
More information about the cfe-commits
mailing list