[PATCH] D152429: [Clang][Type] Add static assertion to guard future expansion for BuiltinType numbering

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 8 08:34:05 PDT 2023


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

Thanks, this generally looks good but I did spot a small change to make (can make it when landing).



================
Comment at: clang/include/clang/AST/Type.h:1542
 
+static const unsigned NumOfBuiltinTypeBits = 8;
+
----------------
I think this should move down to be directly above the definition of `BuiltinTypeBitfields`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152429/new/

https://reviews.llvm.org/D152429



More information about the cfe-commits mailing list