[PATCH] D151730: [RISCV] Support target attribute for function

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/test/CodeGen/RISCV/riscv-func-attr-target.c:2
+// REQUIRES: riscv-registered-target
+// RUN: %clang -target riscv64 -march=rv64g -S %s -o - | FileCheck %s --check-prefix=CHECK-ASM
+// RUN: %clang -target riscv64 -march=rv64g -emit-llvm -S %s -o - | FileCheck %s --check-prefix=CHECK-IR
----------------
`-target ` has been deprecated since Clang 3.x. Use `--target=` for new tests.

Prefer `%clang_cc1` for non-Driver tests. Only use `%clang` in test/Driver


================
Comment at: clang/test/CodeGen/RISCV/riscv-func-attr-target.c:5
+
+// clang-format off
+
----------------
We don't format tests, so this annotation is unneeded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151730/new/

https://reviews.llvm.org/D151730