[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

DonĂ¡t Nagy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 8 05:41:24 PDT 2023


donat.nagy added a comment.

Hmm, I agree that a new checker might be better for the situation when we'd sacrifice a significant amount of TPs, but after reconsidering the situation I think that my concerns are mostly theoretical: if the current code reports an issue, then it's probably not too difficult to provide a concise and useful bug report for it. (And if the issue is an eldritch mess that cannot be described in a concise manner, then it's better to ignore it...)

I might still temporarily "sacrifice" TPs or other advantages during the initial steps of the code reorganization (to keep the commit size more manageable), but I'll pay attention to compensating these in later commits (which may be merged at the same moment as the earlier ones).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150446/new/

https://reviews.llvm.org/D150446



More information about the cfe-commits mailing list