[PATCH] D143075: BareMetal ToolChain multilib layering

[Petr Hosek via Phabricator via cfe-commits]

phosek accepted this revision.
phosek added a comment.

LGTM



================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:236-240
+  if (!SelectedMultilibs.empty()) {
+    return llvm::iterator_range<
+        llvm::SmallVector<Multilib>::const_reverse_iterator>(
+        SelectedMultilibs.rbegin(), SelectedMultilibs.rend());
+  }
----------------
It should be possible to simplify this with `llvm::reverse`.


================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:244-246
+  return llvm::iterator_range<
+      llvm::SmallVector<Multilib>::const_reverse_iterator>(Default.rbegin(),
+                                                           Default.rend());
----------------
It should be possible to simplify this with `llvm::reverse`.


================
Comment at: clang/lib/Driver/ToolChains/BareMetal.h:76
+private:
+  llvm::iterator_range<llvm::SmallVector<Multilib>::const_reverse_iterator>
+  getOrderedMultilibs() const;
----------------
I'd define an alias for this type with `using` to avoid repeating it multiple times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D143075/new/

https://reviews.llvm.org/D143075