[PATCH] D152353: [NFC][Driver] Change MultilibBuilder flags argument order

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jun 8 01:02:51 PDT 2023


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

LGTM thanks!



================
Comment at: clang/include/clang/Driver/MultilibBuilder.h:80
+  /// \p Negate defines whether the flag is negated and therefore disallowed.
+  MultilibBuilder &flag(StringRef Flag, bool Negate = false);
 
----------------
After seeing the change and specifically the comment on this fuinction, I think that `Disallow` might be a better name than `Negate` if it's not too much hassle to change it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152353/new/

https://reviews.llvm.org/D152353



More information about the cfe-commits mailing list