[PATCH] D142932: Multilib YAML parsing

Thu Jun 8 00:58:12 PDT 2023

phosek accepted this revision.
phosek added a comment.

In D142932#4402981 <https://reviews.llvm.org/D142932#4402981>, @michaelplatings wrote:

> @phosek thanks for your suggestion, that's now implemented. In practise for LLVM Embedded Toolchain for Arm we haven't yet needed `NoMatchFlags` so I've removed that feature.

Great, that simplifies things even further. The only other suggestion I have is to maybe rename `FlagMap` to `Mappings` for a better consistency with `Variants`, otherwise LGTM.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142932/new/

https://reviews.llvm.org/D142932