[PATCH] D148385: [RISCV] Implement KCFI operand bundle lowering

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 7 21:33:59 PDT 2023


MaskRay added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:14427
   SDValue Callee = CLI.Callee;
+  bool IsCFICall = CLI.CB && CLI.CB->isIndirectCall() && CLI.CFIType;
   bool &IsTailCall = CLI.IsTailCall;
----------------
If `CLI.CFIType != 0`, is `CLI.CB->isIndirectCall()` possible? If not, add an assert?
This is  an opportunity to save a redundant check.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D148385/new/

https://reviews.llvm.org/D148385



More information about the cfe-commits mailing list