[PATCH] D152403: [Clang][CUDA] Disable diagnostics for neon attrs for GPU-side CUDA compilation

[Alexander Shaposhnikov via Phabricator via cfe-commits]

alexander-shaposhnikov added inline comments.


================
Comment at: clang/lib/Sema/SemaType.cpp:8168
+    IsTargetCUDAAndHostARM =
+        !AuxTI || AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM();
+  }
----------------
tra wrote:
> Should it be `AuxTI && (AuxTI->getTriple().isAArch64() || AuxTI->getTriple().isARM();)` ?
> 
> I don't think we want IsTargetCUDAAndHostARM to be set to true if there's no auxTargetInfo (e.g. during any C++ compilation, regardless of the target).
we get here only if S.getLangOpts().CUDAIsDevice is true, so not for an arbitrary c++ compilation,
iirc AuxTI was null for some tests, but I'm happy to double check,
AuxTI && ... looks better to me too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152403/new/

https://reviews.llvm.org/D152403