[PATCH] D152207: [HIP] Instruct lld to go through all archives

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jun 7 11:41:58 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:184
 
+  // pair with the --whole-archive being added previously
+  LldArgs.push_back("--no-whole-archive");
----------------
For complete sentences in comments, capitalize and add a full stop.

Actually, this statement is self-explanatory and I don't think a comment is useful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152207/new/

https://reviews.llvm.org/D152207



More information about the cfe-commits mailing list