[PATCH] D152207: [HIP] Instruct lld to go through all archives

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIPAMD.cpp:165
+  // --whole-archive flag such that all global symbols would be linked in.
+  LldArgs.push_back("--whole-archive");
+
----------------
Though not strictly required, it's usually better to end `--whole-archive` with a pairing `--no-whole-archive`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152207/new/

https://reviews.llvm.org/D152207