[PATCH] D152285: Add support for the NO_COLOR environment variable

[Jan Niklas Hasse via Phabricator via cfe-commits]

jhasse added a comment.

There's a valid usecase `CLICOLOR_FORCE`: Force color diagnostics. The "disable colors" part of https://bixense.com/clicolors/ is not that important to me, I could change it to point to `NO_COLOR` instead?

btw: I've tried to join the "standards" a few years ago: https://github.com/jcs/no_color/issues/28

Right now I think it would be best to drop `CLICOLOR` and have the following simple rules:

- if `NO_COLOR` set: disable colors
- if `CLICOLOR_FORCE` set: always set colors
- else: isatty

What do you think?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152285/new/

https://reviews.llvm.org/D152285