[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

Wed Jun 7 02:08:34 PDT 2023

mstorsjo added a comment.

In D152318#4402493 <https://reviews.llvm.org/D152318#4402493>, @haowei wrote:

> In D152318#4402234 <https://reviews.llvm.org/D152318#4402234>, @mstorsjo wrote:
>
>> FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. While it does match a GNU binutils tool, I'm kinda curious where it is needed.
>
> llvm-strings exists in the `output_dir/bin` from a local llvm-mingw build using the scripts in your repo. So I think we might need it. I didn't dig into it why it exists in the first place. The current effort is to replicate the results. If it is not required I think there is no harm to added to Fuchsia's Clang configuration.
>
> We are trying to build and setup a automated builder for llvm-mingw project using Fuchsia's Clang toolchain (instead of a pinned version of LLVM from llvm-mingw's build script) and using it to build some Windows host tools.

Ok, I see. Yeah there's not much effort in providing it. I tried digging in to see when I added it, and it seems I added it in https://github.com/mstorsjo/llvm-mingw/commit/55e8aef024faa83c17e18ece15c191bbc1ab7936, without any specific explanation why this particular tool was added, so I guess I added it mostly for completeness. In any case, it doesn't hurt to include it for consistency.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152318/new/

https://reviews.llvm.org/D152318