[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter
Timm Bäder via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 6 23:03:21 PDT 2023
tbaeder added a comment.
In D150843#4401189 <https://reviews.llvm.org/D150843#4401189>, @tahonermann wrote:
> The summary states that the changes are not quite NFC. In that case, we would ideally have a test that demonstrates the changed behavior. Would adding such a test be challenging?
They are NFC, it's just not 100% only a refactoring, since it adds the new ASCII-only case.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150843/new/
https://reviews.llvm.org/D150843
More information about the cfe-commits
mailing list