[PATCH] D142986: Enable multilib.yaml in the BareMetal ToolChain
Petr Hosek via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jun 6 22:52:06 PDT 2023
phosek added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:176
+
+#define MULTILIB_YAML_FILENAME "multilib.yaml"
+
----------------
This is not idiomatic, I couldn't find any instance of `#define` for string literals anywhere in LLVM. I believe the idiomatic LLVM alternative is:
```
static constexpr llvm::StringLiteral MultilibFilename = "multilib.yaml";
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142986/new/
https://reviews.llvm.org/D142986
More information about the cfe-commits
mailing list