[PATCH] D142933: Add -print-multi-selection-flags-experimental option

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 22:38:22 PDT 2023


phosek added inline comments.


================
Comment at: clang/lib/Driver/ToolChain.cpp:250-285
+  // Enumerate boolean flags we care about for the purposes of multilib here.
+  // There must be a smarter way to do it but this gets us started.
+  const struct HasFlag {
+    ID Pos, Neg;
+    bool Default;
+  } HasFlagList[] = {
+      {OPT_fexceptions, OPT_fno_exceptions, true},
----------------
I'd suggest omitting these for the initial version. Ideally we would find a way to specify these more generally through Clang's option parser rather than individually listing all flags here, but that can be done in a follow up change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142933/new/

https://reviews.llvm.org/D142933



More information about the cfe-commits mailing list