[PATCH] D142932: Multilib YAML parsing

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 22:33:54 PDT 2023


phosek added a comment.

The only remaining concern I have is about the YAML schema, specifically the naming of `Regex`, `MatchFlags` and `NoMatchFlags` fields. Specifically, I think it something like this might be cleaner:

  FlagMap:
  - Match: --target=thumbv8(\.[0-9]+)?m\.base-none-unknown-eabi
    Flags: [--target=thumbv6m-none-unknown-eabi]

The fact that the value is a regular expression is implied by  the name of the field `Match` since the term "matching operation" is commonly used with regular expression <https://docs.python.org/3/library/re.html>. For the negative case we could use `NoMatch`.

I'm open to other ideas though, this is just a suggestion.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142932/new/

https://reviews.llvm.org/D142932



More information about the cfe-commits mailing list