[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 14:03:50 PDT 2023


aaron.ballman added a comment.

Thank you for the additions! This should have test coverage in clang/unitttests/libclang/LibclangTest.cpp and a release note.



================
Comment at: clang/tools/libclang/CIndex.cpp:2745
 }
+// TODO these two methods are exactly the same. Can this be expressed better?
+void EnqueueVisitor::EnqueueChildren(const AnnotateAttr *A) {
----------------
We could use a template type and enable_if (for some type safety), then it shares the implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151373/new/

https://reviews.llvm.org/D151373



More information about the cfe-commits mailing list