[PATCH] D150803: [WebAssembly] Add a new `wasm_async` clang attribute for marking async functions.

Tue Jun 6 13:45:31 PDT 2023

brendandahl marked an inline comment as done.
brendandahl added a comment.

In D150803#4389062 <https://reviews.llvm.org/D150803#4389062>, @sunfish wrote:

> In D150803#4389040 <https://reviews.llvm.org/D150803#4389040>, @dschuff wrote:
>
>> Hm, this is interesting because in the long term we plan to have stack switching in wasm, which could allow for similar async behavior that JSPI has, and could be useful in non-web systems. But that's a ways off. The file format we are generating with this CL will be used in emscripten sooner (and we may want to try to stabilize it some point, possibly before pure wasm stack switching is usable in non-web systems).
>> So overall I kind of feel like I could go either way on this. Curious if @sunfish has had any thoughts about async outside of emscripten.
>
> When we do have stack switching, would you anticipate still using this `wasm_async` attribute, or would we switch to something else at that point?

It's unclear to me at the moment how we're going to implement full stack switching with emscripten/llvm. I'm not attached to the `wasm_async` name, so we could be more specific and use `wasm_jspi` or something else?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D150803/new/

https://reviews.llvm.org/D150803