[PATCH] D151820: [clang][WebAssembly] Fix __BIGGEST_ALIGNMENT__ under emscripten

Tue Jun 6 13:44:37 PDT 2023

sbc100 added a comment.

In D151820#4400795 <https://reviews.llvm.org/D151820#4400795>, @tlively wrote:

> In D151820#4385512 <https://reviews.llvm.org/D151820#4385512>, @dschuff wrote:
>
>> I seem to recall that @tlively and I spent a bunch of time with XNNpack chasing down some kind of subtle error that I suspect had to do with alignment, but maybe he remembers that better than I do.
>
> Sorry, I have no recollection of this at all 😬

As far as I can tell the only way this change could break XNNpack if XNN_ALLOCATION_ALIGNMENT = 8 is wrongly set there... as long as that is the correct value for XNN_ALLOCATION_ALIGNMENT I don't see how this change could break it.  If XNN_ALLOCATION_ALIGNMENT is set wrongly this change might expose that bug.. but it seems correct to me.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D151820/new/

https://reviews.llvm.org/D151820