[PATCH] D99201: [HIP] Diagnose unaligned atomic for amdgpu

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 11:38:06 PDT 2023


tra added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:7215
+    // warnings as errors.
+    CmdArgs.push_back("-Werror=atomic-alignment");
   }
----------------
Should it be done from `HIPAMDToolChain::addClangWarningOptions` ?

That's where Darwin does similar propotion from a waring to an error.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99201/new/

https://reviews.llvm.org/D99201



More information about the cfe-commits mailing list