[PATCH] D152279: [Driver] Default -msmall-data-limit= to 0

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 08:36:26 PDT 2023


MaskRay added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2087
     // Not support linker relaxation for PIC.
-    SmallDataLimit = "0";
     if (Args.hasArg(options::OPT_G)) {
       D.Diag(diag::warn_drv_unsupported_sdata);
----------------
The code is written in a confusing way with several problems including the unclear diagnostic. I just left a comment on https://reviews.llvm.org/D57497#4399715 and don't want to address them in this patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152279/new/

https://reviews.llvm.org/D152279



More information about the cfe-commits mailing list