[PATCH] D152069: [1/11][Clang][Type] Expand BuiltinTypeBits from 8 to 16 bits

[Erich Keane via Phabricator via cfe-commits]

erichkeane added inline comments.


================
Comment at: clang/include/clang/AST/Type.h:1652
     /// The kind (BuiltinType::Kind) of builtin type this is.
-    unsigned Kind : 8;
+    unsigned Kind : 16;
   };
----------------
It looks like the largest of the Bitfields in the union uses 32 bits (an unsigned), so this doesn't grow anything as far as I can tell, right?

Based on your requirements, I'd rather we do 1 of 2 things;  

1- Make this 9 bits (or 10, or whatever is NECESSARY).
2- Just make this an `unsigned`, which doesn't grow the size, and put a comment on it that we can steal bits from it if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D152069/new/

https://reviews.llvm.org/D152069