[PATCH] D152255: [analyzer][NFC] Pass the diagnostic message to the TrackConstraintBRVisitor

DonĂ¡t Nagy via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jun 6 04:21:34 PDT 2023


donat.nagy created this revision.
donat.nagy added reviewers: gamesh411, steakhal.
Herald added subscribers: manas, ASDenysPetrov, martong, dkrupp, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun.
Herald added a reviewer: NoQ.
Herald added a project: All.
donat.nagy requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

The `TrackConstraintBRVisitor` should accept a message for the note instead of creating one.
It would let us inject domain-specific knowledge in a non-intrusive way, leading to a more generic visitor.

**//Meta://** This small NFC commit was added to our internal fork by @gamesh411 (although if I understand it correctly @steakhal was also involved in its creation). I'd like to upstream it because I'm planning to release one of our internal checkers (which reports invalid use of bitwise shifts) and it depends on this commit.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D152255

Files:
  clang/include/clang/StaticAnalyzer/Core/BugReporter/BugReporterVisitors.h
  clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D152255.528781.patch
Type: text/x-patch
Size: 4214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20230606/7065b8cd/attachment-0001.bin>


More information about the cfe-commits mailing list